chore: enable PIE (flake8-pie) ruff rule#5150
Open
ogulcanaydogan wants to merge 3 commits into
Open
Conversation
DylanRussell
approved these changes
Apr 27, 2026
Author
|
Thanks for the review @DylanRussell! Could a project member take a look when you have a moment? All checks are green. |
Author
|
Friendly bump @DylanRussell has approved and CI is green. Would appreciate a maintainer review when you have a moment. @srikanthccv @aabmass |
ogulcanaydogan
force-pushed
the
chore/enable-ruff-pie-rule
branch
2 times, most recently
from
261560f to
7b6dbb7
Compare
MikeGoldsmith
approved these changes
May 11, 2026
ogulcanaydogan
force-pushed
the
chore/enable-ruff-pie-rule
branch
2 times, most recently
from
cac4933 to
8ea69ce
Compare
emdneto
approved these changes
May 12, 2026
Part of open-telemetry#4227 Adds `PIE` to the ruff lint select list. Fixes all 49 auto-fixable violations (PIE790 unnecessary pass, PIE804 unnecessary dict kwargs, PIE808 unnecessary range start argument). Suppresses PIE796 on GenAiTokenTypeValues.COMPLETION which is an intentional deprecated alias for OUTPUT sharing the same enum value.
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
ogulcanaydogan
force-pushed
the
chore/enable-ruff-pie-rule
branch
from
8ea69ce to
15a5193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4227
Adds
PIEto the ruff lintselectlist and fixes all violations.What changed
pyproject.toml: added"PIE"to[tool.ruff.lint] selectpassstatements in exception handlersdict(key=value)with{"key": value}literalsstart=0argument fromrange()calls# noqa: PIE796onGenAiTokenTypeValues.COMPLETIONingen_ai_attributes.py— this is an intentional deprecated alias sharing the same enum value asOUTPUTTesting